Fix discovery of test methods in specs #3851
Open
+56
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3722.
Methods starting
test_are picked up my Minitest but were not being discovered by the LSP.Implementation
This commit adds a
#on_def_node_enterhandler to register test items for methods startingtest_in describe blocks. It should not match non-test methods (e.g. helper methods), nor should it match methods namedtest_in non-spec blocks.Automated Tests
I have added a new testfor this fix.
Manual Tests
test_method