Do not raise unnecessarily during parsing #402
Merged
+0
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <[email protected]>
egiurleo
approved these changes
Jan 21, 2025
vinistock
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Shopify/spoom#611, we started using the
RBI::Parserto parse actual Ruby files rather than just RBI files. This means the parser may encounter a more complex syntax than what we can expect in a RBI file and I noticed that we were raising a fewRBI::ParseErrorfor such cases.While these errors may be useful to lint RBI files, the RBI parser is not a linter and shouldn't raise solely for this purpose. In most cases we can just no-op the case and continue without any issue.
This PR removes two cases that raise while we could have continued.