-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Layout foundations] Add POC for AlphaCard migration #7470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kyle Durand <[email protected]>
Contributor
size-limit report 📦
|
Contributor
Author
|
Closing this as it was just a POC and we'll soon have the ability to use a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
⛔️ DO NOT MERGE ⛔️
Resolves #7409.
A POC for a migration to:
CardwithAlphaCardtitleandsectionedprops fromCardtitleandsectionedprops with new layout primitivesWHAT is this pull request doing?
Creates a new
replace-card-componentscript with tests.The script is run in two test cases:
Cardimported from@shopify/polaris—Banner.stories.tsxCardimported fromcomponents—AccountConnection.tsxNote: in the before and after pictures, there is extra padding inside the
Banner -> In a Cardstory because the incorrect classname is being applied. This logic lives insideBannerand would need to be updated there.Banner in a card — before migration
Banner in a card — after migration
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes