[Typography foundations] Deprecate existing typography components on polaris.shopify.com #6915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveline
approved these changes
Aug 10, 2022
chazdean
approved these changes
Aug 11, 2022
laurkim
force-pushed
the
lo/deprecate-typography-components
branch
from
f2816fa to
b20f902
Compare
…e for deprecated components
laurkim
force-pushed
the
lo/deprecate-typography-components
branch
from
b20f902 to
2cd6816
Compare
Based off the work to modify tshirt sizes. #6967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
### ⛔️ DO NOT MERGEAlpha release ofTextcomponent needs to ship first.WHY are these changes introduced?
Resolves #6513.
Once the alpha Text component is released, the existing typography component (
DisplayText,Heading,Subheading,Caption,TextStyle, andVisuallyHidden) docs need to be updated.WHAT is this pull request doing?
DisplayText,Heading,Subheading,Caption,TextStyle, andVisuallyHiddenpagesTextcomponent[components].tsxto only renderComponentExamplesif they exist[components].tsxto only renderPropTablesif the component isn't deprecatedHeading page — before
Heading page — after
🎩 checklist
README.mdwith documentation changes