Stop using Bundler::RubyVersion#to_gem_version_with_patchlevel
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method reports the patch level of Ruby, which is no longer useful since Ruby 2.0.0, and was causing Bundler to show some strange error messages about Ruby version with 4 segments, like 3.1.1.0. The method was removed too aggressively from Bundler without knowing that it was actually being used by bootboot. Depending on how widely it's actually used, we might restore it with a deprecation, but this commit makes bootboot use a better method.
|
This looks like a winner to me. thx @deivid-rodriguez |
nvasilevski
approved these changes
Apr 21, 2022
Contributor
nvasilevski
left a comment
nvasilevski
left a comment
There was a problem hiding this comment.
That's awesome, thank you!
Give me a few moments, I'll try to release a new version by the end of the day EST
deivid-rodriguez
deleted the
remove-to-gem-version-with-patchlevel-usage
branch
Contributor
Author
|
That was fast, thanks so much @nvasilevski! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method reports the patch level of Ruby, which is no longer useful since Ruby 2.0.0, and was causing Bundler to show some strange error messages about Ruby version with 4 segments, like 3.1.1.0.
The method was removed too aggressively from Bundler without knowing that it was actually being used by bootboot. Depending on how widely it's actually used, we might restore it with a deprecation, but this commit makes bootboot use a better method.
Fixes #40.