add step navigation buttons in xray. #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Global Variable Usage Reduces Readability ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| src/agentlab/analyze/agent_xray.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
src/agentlab/analyze/agent_xray.py
Outdated
Comment on lines
554
to
557
| def format_step_indicator(step_id): | ||
| global info | ||
| if not step_id or not info.exp_result or not info.exp_result.steps_info: | ||
| return "Step 0/0" |
There was a problem hiding this comment.
Global Variable Usage Reduces Readability 
Tell me more
What is the issue?
The function uses a global variable which makes the code harder to understand and maintain.
Why this matters
Global state makes code flow harder to follow and increases the likelihood of bugs when the global state changes unexpectedly.
Suggested change ∙ Feature Preview
def format_step_indicator(step_id: StepId, info: Info) -> str:
if not step_id or not info.exp_result or not info.exp_result.steps_info:
return "Step 0/0"Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
recursix
previously approved these changes
Oct 3, 2025
amanjaiswal73892
force-pushed
the
improve-xray
branch
from
8b08c1f to
54a729c
Compare
recursix
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds step navigation buttons and fix keyboard shortcuts.
Description by Korbit AI
What change is being made?
Add a keyboard shortcut and UI navigation for stepping through xray results by introducing Granadio head content with a step navigation bar (Previous/Next buttons and a step indicator) and corresponding navigation handlers.
Why are these changes being made?
Enhance user navigation by enabling quick step-by-step traversal using Ctrl/Cmd + Arrow keys and by providing visible step context through a step indicator and dedicated navigation buttons. This streamlines reviewing multi-step results without relying solely on other UI controls.