Need a workaround to use AK on Ubuntu-18.04 due to "gettid"

[mingodad]

To build on Ubuntu-18.04 I need to add this:

-------------------- bootstrap/stage0/runtime/AK/Format.cpp --------------------
index 43b125cb..58ac662a 100644
@@ -34,6 +34,11 @@
 #    include <AK/StringFloatingPointConversions.h>
 #endif
 
+#if defined(AK_OS_LINUX) && __GLIBC__ == 2 && __GLIBC_MINOR__ < 30
+#include <sys/syscall.h>
+#define gettid() syscall(SYS_gettid)
+#endif
+
 namespace AK {
 
 namespace {

Edited to add check for AK_OS_LINUX.

[nico]

Does adding a

#    include <unistd.h>

after the <time.h> include help too?

[alimpfard]

@nico gettid was added in glibc 2.30: https://www.man7.org/linux/man-pages/man2/gettid.2.html

HISTORY
Linux 2.4.11, glibc 2.30.

[nico]

Oh, Ubuntu-18.04 is ancient 😅

Up to you how far back you want to go with jakt support, I suppose :)

[alimpfard]

I don't really mind supporting older systems in jakt, but AK has to support them too.

[nico]

Understood. If it's just those 5 lines, that seems alright. If it's considerably more messy, maybe it isn't.

[LucasChollet]

Ubuntu 18.04 is quite old indeed. It reached EOL more than one year ago (May 2023).
Isn't there a way for you to upgrade @mingodad ?

[mingodad]

Hello @LucasChollet I have several programs and development tools that do not make it easy for me to upgrade right now and it's working so far for my use cases the needed fix doesn't seem too complicated or have undesired side effects.