Mosquitto service definition - 1 of 2 - master branch #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `service.yml` to coalesce **file** volume references to `mosquitto.conf` and `filter.acl` into a single **directory** volume reference to the `services` directory, and to flag the access as read-only. See also extended discussion at [Issue 269](SensorsIot#269). Changes `mosquitto.conf` to: 1. Improve layout, including grouping like controls. 2. Extend comments on password handling. 3. Fix small typo/bug by removing trailing "/" from `persistence_location` path (this was showing up in the Mosquitto log as "//"). Adds checking preamble to `directoryfix.sh` to mitigate two common mistakes: 1. Prevents invocation from `sudo`; and 2. Warns if the working directory does not appear to be called "IOTstack".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
service.ymlto coalesce file volume references tomosquitto.confandfilter.aclinto a single directory volumereference to the
servicesdirectory, and to flag the access asread-only. See also extended discussion at
Issue 269.
Changes
mosquitto.confto:persistence_locationpath (this was showing up in the Mosquittolog as "//").
Adds checking preamble to
directoryfix.shto mitigate two commonmistakes:
sudo; and"IOTstack".