Skip to content

Conversation

lbaca
Copy link

@lbaca lbaca commented Nov 29, 2020

Yesterday I submitted PR #184 to add Heimdall Application Dashboard, and I thought I'd provide some alternatives to let people choose between three such apps.

I'm kind of new to PRs in general, and I wonder if instead of creating a new branch with a new PR, I should have maybe added more commits to #184? I welcome any feedback and tips for better collaboration.

@Slyke
Copy link
Collaborator

Slyke commented Dec 18, 2020

Hey @lbaca do note that these won't show up in the new menu system once merged in. I'll get around to adding them in. Feel free to create a PR for them with the new system too.

@Slyke Slyke merged commit ffbccf2 into SensorsIot:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants