Skip to content

Conversation

thomas-topway-it
Copy link
Contributor

-- considers this #942

-- fixes #910

-- uses structured queries instead of raw joins in the from clause

LukasGold added a commit to OpenSemanticLab/SemanticResultFormats that referenced this pull request Aug 25, 2025
@alistair3149 alistair3149 changed the base branch from master to feat-datatables-searchpanes-structured-queries September 24, 2025 18:58
@alistair3149 alistair3149 merged commit e7773b3 into SemanticMediaWiki:feat-datatables-searchpanes-structured-queries Sep 24, 2025
0 of 5 checks passed
@alistair3149
Copy link
Member

Merging it to a separate branch for testing

@thomas-topway-it
Copy link
Contributor Author

@alistair3149 I've found out there is an issue with the method parseQuerySegment, sometimes joinConditions and/or fromTables are empty in the root segment. I've found a better solution emulating QuerySegmentListProcessor, and keeping the structured queries, I was about to complete it

@alistair3149
Copy link
Member

@alistair3149 I've found out there is an issue with the method parseQuerySegment, sometimes joinConditions and/or fromTables are empty in the root segment. I've found a better solution emulating QuerySegmentListProcessor, and keeping the structured queries, I was about to complete it

Would you be able to merge them into feat-datatables-searchpanes-structured-queries please? If the change is a complete rewrite, then please let me know and I will remove the branch.

In that way we can keep the branch available on Packagist for easier testing and cleanups.

@thomas-topway-it
Copy link
Contributor Author

@alistair3149 done -- I wanted to test also here https://fina.knowledge.wiki/Test_Datatables but there is some other issue.
After testing, I have a better idea how to use the QuerySegmentListProcessor, but the functionality will be the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[datatables] Table name component contains unexpected quote or dot character with SearchPane

2 participants