Skip to content

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Aug 27, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

fixed line number to show case selenium maven dependency- issue 2447

Description

fixed line number to show case selenium maven dependency- issue 2447

Motivation and Context

fixed line number to show case selenium maven dependency- issue 2447

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Updated Maven dependency line numbers in documentation

  • Fixed references from L30-L34 to L35-L38

  • Applied changes across multiple language versions


Diagram Walkthrough

flowchart LR
  A["Documentation Files"] --> B["Line Number Update"]
  B --> C["Maven Dependency Reference"]
  C --> D["Multiple Languages"]
Loading

File Walkthrough

Relevant files
Documentation
install_library.en.md
Fix Maven dependency line numbers                                               

website_and_docs/content/documentation/webdriver/getting_started/install_library.en.md

  • Updated Maven dependency line reference from L30-L34 to L35-L38
+1/-1     
install_library.ja.md
Fix Maven dependency line numbers                                               

website_and_docs/content/documentation/webdriver/getting_started/install_library.ja.md

  • Updated Maven dependency line reference from L30-L34 to L35-L38
+1/-1     
install_library.pt-br.md
Fix Maven dependency line numbers                                               

website_and_docs/content/documentation/webdriver/getting_started/install_library.pt-br.md

  • Updated Maven dependency line reference from L30-L34 to L35-L38
+1/-1     
install_library.zh-cn.md
Fix Maven dependency line numbers                                               

website_and_docs/content/documentation/webdriver/getting_started/install_library.zh-cn.md

  • Updated Maven dependency line reference from L30-L34 to L35-L38
+1/-1     

Copy link

netlify bot commented Aug 27, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4b010c1

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Reference Accuracy

Verify that the referenced lines L35-L38 in /examples/java/pom.xml actually contain the intended Maven dependencies and that this range stays stable; consider linking to an anchor or snippet tag to avoid future drift.

{{< gh-codeblock path="/examples/java/pom.xml#L35-L38" >}}
Localization Consistency

Ensure the updated codeblock reference renders correctly across localized pages and matches the English source; confirm no layout or shortcode parsing issues in Hugo.

{{< gh-codeblock path="/examples/java/pom.xml#L35-L38" >}}

Copy link
Contributor

qodo-merge-pro bot commented Aug 27, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@pallavigitwork pallavigitwork requested a review from a team September 1, 2025 11:36
Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks

@pallavigitwork
Copy link
Member Author

Thank you.

@pallavigitwork pallavigitwork merged commit 845ea50 into SeleniumHQ:trunk Sep 2, 2025
3 checks passed
@pallavigitwork pallavigitwork deleted the 2447Fix branch September 8, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants