Skip to content

[dotnet] Remove deprecated DevTools capabilities from Firefox options #16047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[dotnet] Remove deprecated DevTools capabilities from Firefox options #16047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions dotnet/src/webdriver/Firefox/FirefoxOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ public class FirefoxOptions : DriverOptions
private const string FirefoxPrefsCapability = "prefs";
private const string FirefoxEnvCapability = "env";
private const string FirefoxOptionsCapability = "moz:firefoxOptions";
private const string FirefoxEnableDevToolsProtocolCapability = "moz:debuggerAddress";
private readonly List<string> firefoxArguments = new List<string>();
private readonly Dictionary<string, object> profilePreferences = new Dictionary<string, object>();
private readonly Dictionary<string, object> additionalFirefoxOptions = new Dictionary<string, object>();
Expand All @@ -82,7 +81,6 @@ public FirefoxOptions()
this.AddKnownCapabilityName(FirefoxOptions.FirefoxLogCapability, "LogLevel property");
this.AddKnownCapabilityName(FirefoxOptions.FirefoxLegacyProfileCapability, "Profile property");
this.AddKnownCapabilityName(FirefoxOptions.FirefoxLegacyBinaryCapability, "BrowserExecutableLocation property");
this.AddKnownCapabilityName(FirefoxOptions.FirefoxEnableDevToolsProtocolCapability, "EnableDevToolsProtocol property");
// https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/.
// Enable BiDi only
this.SetPreference("remote.active-protocols", 1);
Expand Down Expand Up @@ -113,11 +111,6 @@ public string? BrowserExecutableLocation
/// </summary>
public FirefoxDriverLogLevel LogLevel { get; set; } = FirefoxDriverLogLevel.Default;

/// <summary>
/// Gets or sets a value indicating whether to enable the DevTools protocol for the launched browser.
/// </summary>
public bool EnableDevToolsProtocol { get; set; }

/// <summary>
/// Gets or sets the options for automating Firefox on Android.
/// </summary>
Expand Down Expand Up @@ -268,10 +261,6 @@ public override ICapabilities ToCapabilities()
IWritableCapabilities capabilities = GenerateDesiredCapabilities(true);
Dictionary<string, object> firefoxOptions = this.GenerateFirefoxOptionsDictionary();
capabilities.SetCapability(FirefoxOptionsCapability, firefoxOptions);
if (this.EnableDevToolsProtocol)
{
capabilities.SetCapability(FirefoxEnableDevToolsProtocolCapability, true);
}

return capabilities.AsReadOnly();
}
Expand Down
2 changes: 1 addition & 1 deletion dotnet/test/common/CustomDriverConfigs/NightlyChannelFirefoxDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ public NightlyChannelFirefoxDriver(FirefoxDriverService service, FirefoxOptions

public static FirefoxOptions DefaultOptions
{
get { return new FirefoxOptions() { BrowserVersion = "nightly", AcceptInsecureCertificates = true, EnableDevToolsProtocol = true }; }
get { return new FirefoxOptions() { BrowserVersion = "nightly", AcceptInsecureCertificates = true }; }
}
}
2 changes: 1 addition & 1 deletion dotnet/test/common/CustomDriverConfigs/StableChannelFirefoxDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ public StableChannelFirefoxDriver(FirefoxDriverService service, FirefoxOptions o

public static FirefoxOptions DefaultOptions
{
get { return new FirefoxOptions() { AcceptInsecureCertificates = true, EnableDevToolsProtocol = true }; }
get { return new FirefoxOptions() { AcceptInsecureCertificates = true }; }
}
}