Skip to content

[dotnet] Possibility to output internal log messages to file #13249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvborisenko merged 85 commits into from
Dec 7, 2023
Merged

[dotnet] Possibility to output internal log messages to file #13249

nvborisenko merged 85 commits into from
Dec 7, 2023

Conversation

@nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Dec 6, 2023

Continue improvement of internal logging.

Description

  • Added FileLogHandler class which listens to internal log events
  • Fixed issue when copying of log handlers across contexts

Motivation and Context

To be aligned with others bindings, and providing file log handler out of the box.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko
INitial implementation
0688c8b
@nvborisenko
With context
091ee36
@nvborisenko
Update HttpCommandExecutor.cs
eea4ab6
@nvborisenko
Nullable handlers
f8c27f8
@nvborisenko
Don't capture logger
3cee19d
@nvborisenko
Log message issuer
c722c4e
@nvborisenko
Simplify things
16c3cae
@nvborisenko
Merge remote-tracking branch 'upstream/trunk' into dotnet-logging
d7ceb67
@nvborisenko
Continue
2a85e27
@nvborisenko
Merge remote-tracking branch 'upstream/trunk' into dotnet-logging
4fca9a3
@nvborisenko
Update nunit adapter to work with dotnet 7 and be more friendly with …
4c7ba77 
…windows
@nvborisenko
Merge remote-tracking branch 'upstream/trunk' into dotnet-logging
0dc4b35
@nvborisenko
Rename to LogEventLevel
1042d4e
@nvborisenko
Typo
eae7f4c
@nvborisenko
Introduce LogContextManager
0b7c610
@nvborisenko
Typo again
1390b1e
@nvborisenko
Rename to Timestamp
e87773e
@nvborisenko
Make ILogger as static field
b874730
@nvborisenko
Support hierarchical contexts
fcf811c
@nvborisenko
Rename to EmitMessage
3a9dbaf
@nvborisenko
Do not emit message to parent context
ca73016
@nvborisenko
Deep copy of loggers and handlers per context
bf004d6
@nvborisenko
Make fields private
88cb872
@nvborisenko
Static works with current log context
9795e8f
@nvborisenko
Create context with minimum level
6f3e484
@nvborisenko
Set minimum level for context
478ae5a
@nvborisenko
Rename to WithHandler
5f54cfa
@nvborisenko
Set minimum level per issuer
571479a
@nvborisenko
Simplify getting internal logger
edb14d3
@nvborisenko
Use DateTimeOffset
4573398
nvborisenko and others added 22 commits December 1, 2023 12:36
@nvborisenko
Merge branch 'trunk' into dotnet-logging
9663bc3
@nvborisenko
Merge remote-tracking branch 'upstream/trunk' into dotnet-logging
5ff197f
@nvborisenko
Old school using to make bazel happy
0885002
@nvborisenko
Fix targeting packs for test targets
1138648
@nvborisenko
Merge branch 'dotnet-logging' into dotnet-logging-file
bcf9e0c
@nvborisenko
It works
049e646
@nvborisenko
Small clean up
8c952e9
@nvborisenko
Lock in ctor
9f47cb5
@nvborisenko
Dispose at process exit
1a6803e
@nvborisenko
Merge remote-tracking branch 'upstream/trunk' into dotnet-logging-file
bea874f
@nvborisenko
Remove redundant Clone for log handlers
418ae88
@nvborisenko
Dispose log handlers when context finishes
b7e09d6
@nvborisenko
Lock writing to the disk globally
5814e27
@nvborisenko
Fix new list of log handlers for context
001641b
@nvborisenko
Don't lock in ctor
aa9626f
@nvborisenko
Add docs
1a4b87b
@nvborisenko
Change format of datetime in file log
2b19228
@nvborisenko
Thread safe disposing
dbebb14
@nvborisenko
Add finilizer
d368244
@nvborisenko
Docs for finilizer
060cf77
@nvborisenko
Add tests
db63f60
@nvborisenko
Recreating missing dirs
8076316
@titusfortner titusfortner added the C-dotnet .NET Bindings label Dec 7, 2023
@titusfortner titusfortner added this to the 4.17 milestone Dec 7, 2023
@nvborisenko
Copy link
Member Author

nvborisenko commented Dec 7, 2023

This change introduces a breaking change to ILogHandler. I even don't mind to land this feature as v4.16.2. Then docs will be aligned across bindings.

Why now rather than later?
Stabilize public API and avoid breaking changes in future.

@nvborisenko
Copy link
Member Author

nvborisenko commented Dec 7, 2023

Thanks @nvborisenko for your contribution!

@nvborisenko nvborisenko merged commit b949dca into SeleniumHQ:trunk Dec 7, 2023
@nvborisenko nvborisenko deleted the dotnet-logging-file branch December 8, 2023 11:29
YevgeniyShunevych
YevgeniyShunevych reviewed Dec 8, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@YevgeniyShunevych YevgeniyShunevych YevgeniyShunevych left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-dotnet .NET Bindings

Projects

None yet

Milestone

4.17

Development

Successfully merging this pull request may close these issues.

3 participants

@nvborisenko @YevgeniyShunevych @titusfortner