Skip to content

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Close resources in tests

Motivation and Context

Medium tests were facing an issue in running. Ensuring resources are cleaned up properly to see if that helps.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Base: 54.66% // Head: 54.66% // No change to project coverage 👍

Coverage data is based on head (37e9f3e) compared to base (74a85d8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11557   +/-   ##
=======================================
  Coverage   54.66%   54.66%           
=======================================
  Files          85       85           
  Lines        5643     5643           
  Branches      243      243           
=======================================
  Hits         3085     3085           
  Misses       2315     2315           
  Partials      243      243           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pujagani pujagani marked this pull request as ready for review January 18, 2023 12:14
@pujagani pujagani merged commit 215c0fd into SeleniumHQ:trunk Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants