Skip to content

[build] Re-enabling browser-actions/setup-geckodriver@latest #11024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2022
Merged

[build] Re-enabling browser-actions/setup-geckodriver@latest #11024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77be05c
[build] Re-enabling browser-actions/setup-geckodriver@latest.
whimboo Sep 13, 2022
59c175d
[build] make ruby and python use setup-firefox action
titusfortner Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/actions/setup-firefox/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,5 @@ runs:
uses: browser-actions/setup-firefox@latest
with:
firefox-version: ${{ inputs.version }}
- name: Check GeckoDriver
run: geckodriver --version
shell: bash
# Deactivating until https://github.com/mozilla/geckodriver/issues/2009 gets fixed
# - name: Setup GeckoDriver
# uses: browser-actions/setup-geckodriver@latest
- name: Setup geckodriver
uses: browser-actions/setup-geckodriver@latest
12 changes: 4 additions & 8 deletions .github/workflows/ci-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,8 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: '11'
- name: Setup Firefox
uses: browser-actions/setup-firefox@latest
- name: Setup GeckoDriver
uses: browser-actions/setup-geckodriver@latest
- name: Setup Firefox and GeckoDriver
uses: ./.github/actions/setup-firefox
- name: Start XVFB
run: Xvfb :99 &
- name: Run browser tests in Firefox (Remote)
Expand Down Expand Up @@ -219,10 +217,8 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: '11'
- name: Setup Firefox
uses: browser-actions/setup-firefox@latest
- name: Setup GeckoDriver
uses: browser-actions/setup-geckodriver@latest
- name: Setup Firefox and GeckoDriver
uses: ./.github/actions/setup-firefox
- name: Start XVFB
run: Xvfb :99 &
- name: Run browser tests in Firefox
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/ci-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,8 @@ jobs:
restore-keys: |
${{ runner.os }}-bazel-ruby-${{ matrix.target }}-
- uses: ./.github/actions/setup-bazelisk
- name: Setup Firefox
uses: browser-actions/setup-firefox@latest
- name: Setup GeckoDriver
uses: browser-actions/setup-geckodriver@latest
- name: Setup Firefox and GeckoDriver
uses: ./.github/actions/setup-firefox
- run: Xvfb :99 &
- uses: ./.github/actions/bazel
with:
Expand Down