Remove quote to work headless mode #550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review my PR? |
|
Hi @mtsmfm, Can you please update your fork with the latest changes from master? The we can review the PR. |
`docker run --rm --cap-add SYS_ADMIN selenium/standalone-chrome-debug /opt/google/chrome/chrome --no-sandbox --headless --disable-gpu --dump-dom http://example.com` works but `docker run --rm --cap-add SYS_ADMIN selenium/standalone-chrome-debug google-chrome --no-sandbox --headless --disable-gpu --dump-dom http://example.com` doesn't because of this quote. ``` $ docker run --rm --cap-add SYS_ADMIN selenium/standalone-chrome-debug google-chrome --no-sandbox --headless --disable-gpu --dump-dom http://example.com [0904/164342.556447:ERROR:headless_shell.cc(501)] Open multiple tabs is only supported when remote debugging is enabled. ```
|
@diemol Updated! |
|
Hi @mtsmfm, I am sorry, I didn't realise that this PR was conflicting with #578. But the good news is that after releasing Therefore this PR is not needed anymore, I'll close it. If you find something else that needs to be improved in this project, please don't doubt to submit a new PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker run --rm --cap-add SYS_ADMIN selenium/standalone-chrome-debug /opt/google/chrome/chrome --no-sandbox --headless --disable-gpu --dump-dom http://example.comworks butdocker run --rm --cap-add SYS_ADMIN selenium/standalone-chrome-debug google-chrome --no-sandbox --headless --disable-gpu --dump-dom http://example.comdoesn't because of this quote.Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement