Skip to content

Fix add-cert-helper.sh only adding a single certificate in Chrome #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Fix add-cert-helper.sh only adding a single certificate in Chrome #2660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
407d610
Fix add-cert-helper.sh to use different aliases
PeterUpfold Feb 17, 2025
7fb3e51
Update test to support multiple custom CA certs
PeterUpfold Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/selenium-grid/certs/add-cert-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ TARGET_CERT_DIR=${TARGET_CERT_DIR:-"/usr/local/share/ca-certificates"} # Target
BUNDLE_CA_CERTS=${BUNDLE_CA_CERTS:-"/etc/ssl/certs/ca-certificates.crt"} # Bundle CA certificates
NSSDB_HOME=${NSSDB_HOME:-"${HOME}/.pki/nssdb"} # Default location of the NSSDB
APPEND_CRT_KEY="/tmp/tls.crt"
ALIAS=${ALIAS:-"SeleniumHQ"}
ALIAS_PREFIX=${ALIAS_PREFIX:-"SeleniumHQ"}

sudo mkdir -p ${TARGET_CERT_DIR}

Expand All @@ -75,6 +75,7 @@ for cert_file in "${cert_files[@]}"; do
else
echo "Processing $cert_file"
fi
ALIAS="${ALIAS_PREFIX}_$(basename $cert_file)"
cert_file=$(append_private_key_if_exists $cert_file)
for cert_db_file in "${cert_db_files[@]}"; do
echo "Adding to db: $cert_db_file"
Expand Down
2 changes: 1 addition & 1 deletion tests/customCACert/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ docker build ${COMMON_BUILD_ARGS} --build-arg BASE=node-edge -t ${NAMESPACE}/nod

list_cert_files=($(find ./charts/selenium-grid/certs/ -name "*.crt"))
for cert_file_path in "${list_cert_files[@]}"; do
cert_nick_name="SeleniumHQ"
cert_nick_name="SeleniumHQ_$(basename $cert_file_path)"
docker run --entrypoint="" --rm ${NAMESPACE}/node-chrome:${VERSION} bash -c "certutil -L -d sql:/home/seluser/.pki/nssdb -n ${cert_nick_name}"
docker run --entrypoint="" --rm ${NAMESPACE}/node-firefox:${VERSION} bash -c "certutil -L -d sql:/home/seluser/.pki/nssdb -n ${cert_nick_name}"
docker run --entrypoint="" --rm ${NAMESPACE}/node-edge:${VERSION} bash -c "certutil -L -d sql:/home/seluser/.pki/nssdb -n ${cert_nick_name}"
Expand Down
Loading