#67: drop Python 3.8, add Python 3.13. #68
Conversation
| the_actor.attempts_to(AttachTheFile(self.path, **self.attach_kwargs)) | ||
| the_actor.attempts_to(AttachTheFile(str(self.path), **self.attach_kwargs)) |
There was a problem hiding this comment.
So, i want to update this to a Path in AttachTheFile, but i need to release screenpy first. Debating releasing ScreenPy, then updating this bit (and the bit in SaveScreenshot too), then releasing this. Gonna have to remember to do that so let's release 5.0 soon!
There was a problem hiding this comment.
If you want this to be Path, then I suggest removing str() here and let mypy complain until we release the screenpy update. In it's current state, the tests are failing because it's expecting Path in called args but getting a string.
| opts.set_capability( | ||
| "deviceName", os.getenv("IOS_DEVICE_NAME", "iPhone Simulator") | ||
| "deviceName", | ||
| os.getenv("IOS_DEVICE_NAME", "iPhone Simulator"), |
There was a problem hiding this comment.
I thought we removed the ruff rule that was adding in the extra commas?
| the_chain.move_to_element_with_offset( | ||
| self.target.found_by(the_actor), *self.offset | ||
| self.target.found_by(the_actor), | ||
| *self.offset, |
There was a problem hiding this comment.
ruff rule COM812 should not be in the configuration anymore. No need to add the comma here.
There was a problem hiding this comment.
COMB812 is ignored; rerunning the lint does not change this back. Could there be a preference to list multiple arguments on separate lines when we need to linebreak for length? I haven't combed through the rules to find why this might be happening.
| def describe(self) -> str: | ||
| """Describe the Action in present tense.""" | ||
| return f"Save browser console log as {self.filename}" | ||
| return f"Save browser console log as {self.path.name}" |
There was a problem hiding this comment.
I'm a little confused; after adding the property filename why change this line?
There was a problem hiding this comment.
I think i'm also confused. I thought i removed the filename property. 😵
I'll figure out what i meant here.
There was a problem hiding this comment.
OH! I think this was a series of changes. I removed the filename set in __init__. Then realized the describe methods needed to describe the filepath, so i changed them to self.path.name. Then later decided to use a property for a different reason and made filename, but forgot to change the describe methods!
Thanks for your close attention; nice catch!
|
|
||
| if self.attach_kwargs is not None: | ||
| the_actor.attempts_to(AttachTheFile(self.path, **self.attach_kwargs)) | ||
| the_actor.attempts_to(AttachTheFile(str(self.path), **self.attach_kwargs)) |
There was a problem hiding this comment.
I agree with your comment above; we should not wrap self.path in str().
|
As we expect, |
2 participants
You know the drill—we're dropping Python 3.8 and adding Python 3.13. Sorry this one took me longer to get out—i had some typing things that i had to bellyache to myself about. I'll point them out in a comment below.