#7: Remove Python 3.8 support, add Python 3.13 support #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screenpy_appium/common.py
Outdated
|
|
||
| @wraps(func) | ||
| def wrapper(*args: P.args, **kwargs: P.kwargs) -> Function: | ||
| def wrapper(*args: P.args, **kwargs: P.kwargs) -> Callable[P, T]: |
There was a problem hiding this comment.
Dang, this was so so so incorrect. I'm actually surprised even the old mypy allowed it.
This is what it should be:
def pos_args_deprecated(*keywords: str) -> Callable[[Callable[P, T]], Callable[P, T]]:
"""Warn users which positional arguments should be called via keyword."""
def deprecated(func: Callable[P, T]) -> Callable[P, T]:
argnames = func.__code__.co_varnames[: func.__code__.co_argcount]
i = min([argnames.index(kw) for kw in keywords])
kw_argnames = argnames[i:]
@wraps(func)
def wrapper(*args: P.args, **kwargs: P.kwargs) -> T:
bandophahita
requested changes
Jul 23, 2025
| driver = the_actor.ability_to(UseAMobileDevice).driver | ||
| try: | ||
| return driver.find_element(*self) | ||
| # bug in Selenium https://github.com/SeleniumHQ/selenium/issues/16035 |
There was a problem hiding this comment.
There was a problem hiding this comment.
The Appium team was fast -- they released 5.1.3 with the changes that fix the mypy error here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 has reached its end-of-life, so let's remove that. Also let's add Python 3.13 while we're at it, and update all the files to use the new rules from
black,ruff, andmypy!This PR is almost entirely mechanical, with some small tweaks for
mypyto be happy.