New Features, Examples Refactoring and Bug Fix - Unit Tests #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| assert "link_urls" in result_state | ||
| assert "img_urls" in result_state | ||
|
|
||
| assert "https://example.com" in result_state["link_urls"] |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 11 months ago
To fix the problem, we need to ensure that the URL is properly parsed and validated before performing the check. This can be done by using the urlparse function from the urllib.parse module to extract the hostname and then performing the check on the parsed hostname.
- Parse the URL using
urlparseto extract the hostname. - Check if the hostname matches the expected value.
- Update the test case to use this new validation method.
Suggested changeset
1
tests/test_parse_node.py
| @@ -111,5 +111,9 @@ | ||
|
|
||
| assert "https://example.com" in result_state["link_urls"] | ||
| assert "https://sourcesite.com/relative/path.html" in result_state["link_urls"] | ||
| assert "https://sourcesite.com/image.jpg" in result_state["img_urls"] | ||
| from urllib.parse import urlparse | ||
| def get_hostname(url): | ||
| return urlparse(url).hostname | ||
|
|
||
| assert any(get_hostname(url) == "example.com" for url in result_state["link_urls"]) | ||
| assert any(get_hostname(url) == "sourcesite.com" and url.endswith("/relative/path.html") for url in result_state["link_urls"]) | ||
| assert any(get_hostname(url) == "sourcesite.com" and url.endswith("/image.jpg") for url in result_state["img_urls"]) | ||
| assert len(result_state["chunks"]) > 0 |
Copilot is powered by AI and may make mistakes. Always verify output.
VinciGit00
requested changes
Jan 12, 2025
codebeaver-ai
bot
deleted the
codebeaver/pre/beta-tests-20250112_122537
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Coverage Improvements 🎯
This PR adds new tests to improve coverage across multiple files.
Summary
Detailed Changes
tests/test_split_text_into_chunks.pytests/test_tokenizer.pytests/test_tokenizer_openai.pytests/test_parse_node.pytests/test_generate_answer_node.pytests/test_chromium.py