fix locator #78
Merged
fix locator #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of the expected image differences involve the tick values of the isotherms and/or dry adiabats, which were miss-calculated due to the true division porting bug. There are 6 test failures, but there are only 3 new images due to the test duplication i.e., three groups of two tests generate the same image.
|
This was referenced Apr 29, 2022
jamesp
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug resulting from porting from
py2topy3involving true division instead of integer division.This fix is required by users for the next release.
Note that there are expected image differences, so the SciTools/test-tephi-imagehash#8 requires to be merged first before this PR will pass.