Skip to content

Conversation

@rcomer
Copy link
Member

@rcomer rcomer commented Jun 28, 2022

Renamed gallery test known good images to be consistent with SciTools/iris#4792. I have to admit I didn't give much thought to the new names, just went with what seemed like an easy way to simplify them.

@rcomer rcomer changed the title Pytest gallerytests Pytest gallery tests Jun 28, 2022
@rcomer rcomer closed this Jun 28, 2022
@rcomer rcomer reopened this Jun 28, 2022
@rcomer
Copy link
Member Author

rcomer commented Jun 28, 2022

I'm unclear why some files say "Diff not rendered." rather than "File renamed without changes." I tried again with a clean branch and did nothing other than git mv on the files, but got the same result. 🤷‍♀️

@wjbenfold wjbenfold self-requested a review August 13, 2022 09:13
Copy link
Contributor

@wjbenfold wjbenfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with SciTools/iris#4792 when I check both out

@wjbenfold wjbenfold merged commit 51f7b62 into SciTools:master Aug 13, 2022
@rcomer rcomer deleted the pytest-gallerytests branch August 15, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants