CLBlast for linux #487
Merged
CLBlast for linux #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds CLBLAST support for linux, and makes sure to copy the clblast shared library on both windows and linux to the artifacts.
…ive this build is.
jasoncouture
force-pushed
the
clblast_linux
branch
from
b8ad6a6 to
f7a6eaa
Compare
martindevans
requested changes
Feb 5, 2024
|
Just one small review change. Other than that this looks great, thanks! |
martindevans
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #464 I had hoped to support linux as well as windows, and I was able to (after some digging through llamacpp source) figure out how to do it.
This PR adds clblast on linux, and in addition to that, also copies the shared library for clblast to the artifact. This should, but may not always allow clblast to function without any additional local installations. Users may still need to install other dependencies.