Fix Batching Issues #1045
Merged
Fix Batching Issues #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…batching in general)
…causing problems with tokens that should never have been shared. - Added a helper to simplify sampling a conversation with a sampling pipeline - Added many more comments explaining BatchedExecutorSimple in detail
|
Love it. New comments in the sample answered some questions I didn't even know I wanted to ask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1038 a new example was merged. However, this exposed a bug in the batching mechanism, sharing tokens when they shouldn't be shared. This PR completely removes the token sharing mechanism - tokens are only shared if the methods which explicitly add tokens to multiple sequences are used. While working on this I added some extra sanity checking to the batch, which I've left in place (
DEBUGonly).I've also added more details explaining the
BatchedExecutorSimpleexample, in particular explaining the NoKvSlot error which confuses a lot of people. @phil-scott-78 this may interest you :)