Make application/javascript a text type #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While mime-types handles application/javascript as a non-text, IRuby needs to handle it as a text. The new `ascii?` private method judges whether the given mime type is text. This method handles application/javascript as a text in the special case. [Fix GH-292]
Member
|
I should have suqash and merge... 😓 |
Contributor
Author
|
I don't like squash and merge because it does not mark the branch in the local working copy as merged. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 29, 2021
0.7.0 (2021-05-28) Enhancements * The default backend is changed to IRB (@mrkn) * Add IRuby::Kernel#switch_backend! method (@mrkn) Bug Fixes * Fix the handling of image/svg+xml SciRuby/iruby#300, SciRuby/iruby#301 (@kojix2) 0.6.1 (2021-05-26) Bug Fixes * Follow the messages and hooks orders during execute_request processing (@mrkn) 0.6.0 (2021-05-25) Bug Fixes * Fix the handling of application/javascript SciRuby/iruby#292, SciRuby/iruby#294 (@kylekyle, @mrkn) Enhancements * Add the initialized event in IRuby::Kernel class SciRuby/iruby#168, SciRuby/iruby#296 (@Yuki-Inoue, @mrkn) * Add the following four events SciRuby/iruby#295 (@mrkn): - pre-execute -- occurs before every code execution - pre-run-cell -- occurs before every non-silent code execution - post-execute -- occurs after every code execution - post-run-cell -- occurs after every non-silent code execution * Replace Bond with IRB in PlainBackend SciRuby/iruby#276, SciRuby/iruby#297 (@cfis, @mrkn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While mime-types handles application/javascript as a non-text, IRuby needs to
handle it as a text.
The new
ascii?private method judges whether the given mime type is text.This method handles application/javascript as a text in the special case.
[Fix GH-292]