Skip to content

Conversation

DhairyaLGandhi
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This is in continuation from #1193. Here, the return type for some common operations might change, so this might be considered breaking

Zygote.gradient(sol) do sol
    o = reduce(hcat, state_values(sol))
    sum(o)
end

Zygote.gradient(sol) do sol
    o = reduce(hcat, sol.u)
    sum(o)
end

etc go from returning solution types to Tangent types instead

Add any other context about the problem here.

@DhairyaLGandhi
Copy link
Member Author

One of the errors is SciML/SciMLBase.jl#1020

@ChrisRackauckas ChrisRackauckas merged commit 6c3a328 into master May 13, 2025
25 of 42 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dg/rm_getp branch May 13, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants