-
-
Notifications
You must be signed in to change notification settings - Fork 7
Basic building blocks and CSTR #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic building blocks and CSTR #17
Conversation
p(t), [description="pressure"] #, unit=u"Pa"] | ||
h(t), [description="molar enthalpy", output=true] #, unit=u"J mol^-1"] | ||
xᵢ(t)[1:ms.N_c], [description="mole fractions", output=true] #, unit=u"mol mol^-1"] | ||
n(t), [description="total molar flow", connect=Flow] #, unit=u"mol s^-1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you have 2 reactors connected into a tank, are mole fractions
handled appropriately by the connect
equations? I see from the commits that this went from Stream to output=true. Is output=true
similar to Stream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, Stream
connectors would be the better choice here, but their equations were missing as reported here. The output=true
is only used to prevent warnings when creating the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also encountered a very similar bug (singly-connected system works when I use an Across connector, fails when I use a Stream connector). We should open an MTK issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the stream equations are missing in my case too. Haven't tried to get rid of the subsystem. I'll do an MWE on Friday if no one beats me to it.
ControlVolume
as basic building block containing energy and mass balancesMaterialStream
as basic (homogeneous) connectorMaterialSource
struct +Reaction
structControlVolume