Fix: reinit! error when using AbsTerminationMode #699
Merged
+22
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Additional context
Fixed an issue where calling
reinit!
withAbsTerminationMode
would throw:Root Cause
The
NonlinearTerminationModeCache
forAbsTerminationMode
initializesu
asnothing
, butreinit!
attempted to broadcast into it. The fix ensures we only updatecache.u
when it's notnothing
.Solution
Added guard clause to skip updating
cache.u
when it'snothing
:Verification
Added regression test that creates a termination cache with
u_unaliased = nothing
and verifiesreinit!
no longer throws:Resolves #687.