Skip to content

Fixes issue #234 using same inputs #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Thermal/HeatTransfer/sources.jl
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ the component FixedHeatFlow is connected, if parameter `Q_flow` is positive.
end

@equations begin
port.Q_flow ~ -Q_flow * (1 + alpha * (port.T - T_ref))
port.Q_flow ~ ifelse(alpha == 0.0,
-Q_flow, # Simplified equation when alpha is 0
-Q_flow * (1 + alpha * (port.T - T_ref)))
end
end

Expand Down
27 changes: 27 additions & 0 deletions test/Thermal/thermal.jl
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,30 @@ end
zeros(length(sol[collector.port_b.Q_flow]))
@test sol[collector.port_b.T] == sol[collector.port_a1.T] == sol[collector.port_a2.T]
end

@testset "FixedHeatFlow with alpha=0.0 test" begin
@mtkmodel TestModel begin

@components begin
temp = FixedTemperature(T=300)
heatflow = FixedHeatFlow(Q_flow=-1.0)
wall = ThermalResistor(R=1)
end

@equations begin
connect(temp.port, wall.port_a)
connect(wall.port_b, heatflow.port)
end

end

@info "Building a FixedHeatFlow with alpha=0.0"
@mtkbuild test_model = TestModel()
prob = ODEProblem(test_model, Pair[], (0, 10.0))
sol = solve(prob)

heat_flow = sol[test_model.heatflow.port.Q_flow]

@test SciMLBase.successful_retcode(sol) # Ensure the simulation is successful
@test all(isapprox.(heat_flow, 1.0, rtol=1e-6)) # Heat flow value should be equal to the fixed value defined
end
Loading