fix: support GPUs again #4018
Open
fix: support GPUs again #4018
+35
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
|
Add a test for |
Member
Author
|
Yeah I'm working on it. It's astonishing how many tests break if I change the |
AayushSabharwal
force-pushed
the
as/gpu-stuff
branch
from
9b085d8 to
5a9700d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+15
to
+16
| constant::C, nonnumeric::N, | ||
| caches::H) where {T, I, D, C, N, H} |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| constant::C, nonnumeric::N, | |
| caches::H) where {T, I, D, C, N, H} | |
| constant::C, nonnumeric::N, | |
| caches::H) where {T, I, D, C, N, H} |
Comment on lines
+24
to
+25
| discrete, constant, | ||
| nonnumeric, caches) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| discrete, constant, | |
| nonnumeric, caches) | |
| discrete, constant, | |
| nonnumeric, caches) |
Comment on lines
+28
to
+29
| constant::C, nonnumeric::N, | ||
| caches::H) where {T, I, D, C, N, H} |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| constant::C, nonnumeric::N, | |
| caches::H) where {T, I, D, C, N, H} | |
| constant::C, nonnumeric::N, | |
| caches::H) where {T, I, D, C, N, H} |
| constant::C, nonnumeric::N, | ||
| caches::H) where {T, I, D, C, N, H} | ||
| return MTKParameters{T, I, D, C, N, H}(tunables, initials, discrete, constant, | ||
| nonnumeric, caches) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| nonnumeric, caches) | |
| nonnumeric, caches) |
| buffer, repack, _ = SciMLStructures.canonicalize(SciMLStructures.Initials(), initp) | ||
| initp = repack(floatT.(buffer)) | ||
| if !(initp.initials isa StaticVector{0}) | ||
| buffer, repack, _ = SciMLStructures.canonicalize(SciMLStructures.Initials(), initp) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| buffer, repack, _ = SciMLStructures.canonicalize(SciMLStructures.Initials(), initp) | |
| buffer, repack, | |
| _ = SciMLStructures.canonicalize(SciMLStructures.Initials(), initp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.