Skip to content

fix: fix add_fallbacks! #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: fix add_fallbacks! #3332

merged 2 commits into from
Jan 21, 2025

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Jan 16, 2025 •
edited
Loading

No description provided.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review January 17, 2025 13:51
@ChrisRackauckas
Copy link
Member

What is this for?

@AayushSabharwal
Copy link
Member Author

add_fallbacks! is used to populate the operating point with values from defaults if not explicitly provided, handling array variables and reporting the variables that don't have a default or an entry in u0map/pmap. The bug was get(fallbacks, var, nothing)[idx]) for scalarized array variables, where if var isn't present in fallbacks it would try to call getindex(::Nothing, ::CartesianIndex) which doesn't work. I just managed to MWE it and added a test.

@ChrisRackauckas ChrisRackauckas merged commit d3120e7 into SciML:master Jan 21, 2025
34 of 42 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-add-fallbacks branch January 21, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AayushSabharwal @ChrisRackauckas