Skip to content

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as draft November 8, 2024 12:00
@AayushSabharwal
Copy link
Member Author

I realized polynomial checking doesn't take into account observed variables, so we don't report a nice error.

Comment on lines 66 to 67
@parameters n::Integer = 4
@mtkbuild sys = NonlinearSystem([x^n + x^2 - 1 ~ 0])
Copy link
Member

@isaacsas isaacsas Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supporting integer parameter exponents is a pretty big limitation. It means that very common expressions in bio/pharma modeling, Hill expressions, would not be usable here (i.e. terms like x^n / (K + x^n) where n is an integer parameter). Is there no way to handle them? They should, ultimately, reduce down to polynomials once the denominators are removed and the integer exponent values are substituted in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. We can't cache the start system with parametric exponents. @ChrisRackauckas I guess we just have to do the caching optionally?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't the hill functions in this case use @constant?

Copy link
Member Author

@AayushSabharwal AayushSabharwal Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also worth noting that pure HomotopyContinuation.jl doesn't allow parametric exponents either.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parametric exponents are re-allowed with a warning

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review November 9, 2024 18:17
@AayushSabharwal
Copy link
Member Author

Extension test failures are BifurcationKit failing to precompile

@ChrisRackauckas
Copy link
Member

But this would be in extension tests. Just flip the order so we can see it pass.

@ChrisRackauckas ChrisRackauckas merged commit b52bce7 into SciML:master Nov 10, 2024
31 of 39 checks passed
@AayushSabharwal AayushSabharwal deleted the as/hc-cache-startsys branch November 11, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants