Skip to content

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@cstjean
Copy link
Contributor

cstjean commented Oct 18, 2024

❤️

Would be nice to also revamp the Getting started with ModelingToolkit tutorial. Having f call an external f_fun which itself relies on a global variable was a big turn-off when I first looked into external data support.

{6B1383BF-237F-4ABB-ABA4-2F8632027B82}

@ChrisRackauckas ChrisRackauckas merged commit 2378f42 into SciML:master Oct 18, 2024
3 of 4 checks passed
@AayushSabharwal AayushSabharwal deleted the as/callable-docs branch October 18, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants