feat: allow users to set array length via args in @mtkmodel
#3055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ven-k
force-pushed
the
vkb/array-length-as-input
branch
2 times, most recently
from
db10baf to
876c062
Compare
|
Those units tests aren't failing on master? Is that a parsing issue? |
|
Now I've added MTK.convert_units to arrays too; this should fix that error. |
|
The downstream test failures are consistent with the master. |
These are related to: - Model.structure metadata related to variable/parameter array - Certain cases of symtypes (although neither case is unchanged by this PR)
This also fixes more tests
ven-k
force-pushed
the
vkb/array-length-as-input
branch
from
ee2084c to
563dedc
Compare
|
I've rebased the PR with latest master; this PR is ready for review. |
ChrisRackauckas
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mtkmodel@mtkmodel.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional Info: