Skip to content

Conversation

hersle
Copy link
Contributor

@hersle hersle commented Aug 13, 2024

This is a suggestion to expose the independent variable as a system property, on equal footing with variables and parameters.

I think this is more consistent than not doing it. If a user is handed a system sys from somewhere outside their control (like a factory function that uses t internally), it also makes it possible for them to easily obtain sol[sys.t] without any workaround.

What do you think about this?

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@ChrisRackauckas ChrisRackauckas merged commit c113dd1 into SciML:master Aug 20, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants