support JumpProblems over ODEProblems #2946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable more automatic VariableRateJump handling.
@AayushSabharwal this is supposed to allow JumpProblems over ODEProblems, but symbolic indexing of solutions and plotting / plot legends are not working. I just copied how we did JumpProblems over DiscreteProblems, but that doesn't seem to work? Can you let me know how to update the dummy ODEProblem(::JumpSystem,...) here to get it working? Thanks!TODO:
Fix dependency graph generation to ignoreVariableRateJump
s and add tests.Get symbolic indexing working for the resulting solutionsBasic
plot(sol)
is currently broken but that is more of a SciMLBase / JumpProcesses issue from the ExtendedJumpArrays. Plotting works with explicit specification of indexes to plot.Edit: Needs JumpProcesses 438 and a JumpProcesses release.