Default to using fully_determined when possible in initialization #2909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should give better error messages
ChrisRackauckas
force-pushed
the
ChrisRackauckas-patch-5
branch
from
cacd3ce to
c78d13a
Compare
|
I'm not sure this is legal in general. Counting the number of equations does not actually give if fully determined since there might be trivial equations, and the tests suggest that's not too uncommon for initializations? @YingboMa opinion? |
|
What if we make it so that passing |
YingboMa
reviewed
Oct 25, 2024
|
The DAE system would have to already be structurally simplified at this point, so it should be index 1 or have errored already? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give better error messages