Skip to content

Regression: Can no longer solve SteadyStateProblems after remake #3483

@TorkelE

Description

@TorkelE

This one popped up in the Catalyst tests yesterday, or soon before that:

using ModelingToolkit, SteadyStateDiffEq, OrdinaryDiffEqTsit5
using ModelingToolkit: t_nounits as t, D_nounits as D

@variables (X(t)[1:2])
@parameters p[1:2] d[1:2]
eqs = [
    D(X[1]) ~ p[1] - d[1]*X[1],
    D(X[2]) ~ p[2] - d[2]*X[2]
]
@mtkbuild osys = ODESystem(eqs, t)
ssprob = SteadyStateProblem(osys, [X => [1.0, 2.0]], [p => [1.0, 2.0], d => [2.0, 3.0]])
ssprob = remake(ssprob; u0 = [X => [1.0, 2.0]], p = [p => [1.0, 2.0], d => [2.0, 3.0]])
solve(ssprob, DynamicSS(Tsit5()))
ERROR: TypeError: in validate_parameter_type, in Parameter ModelingToolkit.ParameterIndex{SciMLStructures.Tunable, Int64}(SciMLStructures.Tunable(), 5, false), expected Real, got a value of type Nothing
Stacktrace:
  [1] validate_parameter_type(ic::ModelingToolkit.IndexCache, stype::Type, sz::Symbolics.Unknown, sym::Nothing, index::ModelingToolkit.ParameterIndex{…}, val::Nothing)
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/ZOG3I/src/systems/parameter_buffer.jl:480
  [2] validate_parameter_type
    @ ~/.julia/packages/ModelingToolkit/ZOG3I/src/systems/parameter_buffer.jl:441 [inlined]
  [3] (::ModelingToolkit.var"#handle_parameter#205"{…})(ic::ModelingToolkit.IndexCache, sym::Nothing, idx::ModelingToolkit.ParameterIndex{…}, val::Nothing)
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/ZOG3I/src/systems/parameter_buffer.jl:506
  [4] _remake_buffer(indp::NonlinearSystem, oldbuf::MTKParameters{…}, idxs::Vector{…}, vals::Vector{…}; validate::Bool)
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/ZOG3I/src/systems/parameter_buffer.jl:564
  [5] _remake_buffer
    @ ~/.julia/packages/ModelingToolkit/ZOG3I/src/systems/parameter_buffer.jl:496 [inlined]
  [6] remake_buffer
    @ ~/.julia/packages/ModelingToolkit/ZOG3I/src/systems/parameter_buffer.jl:494 [inlined]
  [7] (::SymbolicIndexingInterface.OOPSetter{…})(valp::NonlinearProblem{…}, val::Vector{…})
    @ SymbolicIndexingInterface ~/.julia/packages/SymbolicIndexingInterface/gQU1g/src/value_provider_interface.jl:256
  [8] (::ModelingToolkit.ReconstructInitializeprob)(srcvalp::SymbolicIndexingInterface.ProblemState{…}, dstvalp::NonlinearProblem{…})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/ZOG3I/src/systems/nonlinear/initializesystem.jl:455
  [9] remake_initialization_data(sys::ODESystem, odefn::Function, u0::Vector{…}, t0::Nothing, p::MTKParameters{…}, newu0::Vector{…}, newp::MTKParameters{…})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/ZOG3I/src/systems/nonlinear/initializesystem.jl:567
 [10] remake(prob::SteadyStateProblem{…}; f::Missing, u0::Vector{…}, p::MTKParameters{…}, kwargs::Missing, interpret_symbolicmap::Bool, use_defaults::Bool, lazy_initialization::Nothing, build_initializeprob::Bool, _kwargs::@Kwargs{})
    @ SciMLBase ~/.julia/packages/SciMLBase/WsQwM/src/remake.jl:732
 [11] remake
    @ ~/.julia/packages/SciMLBase/WsQwM/src/remake.jl:715 [inlined]
 [12] get_concrete_problem(prob::SteadyStateProblem{…}, isadapt::Bool; kwargs::@Kwargs{…})
    @ DiffEqBase ~/.julia/packages/DiffEqBase/y5GOy/src/solve.jl:1198
 [13] get_concrete_problem
    @ ~/.julia/packages/DiffEqBase/y5GOy/src/solve.jl:1194 [inlined]
 [14] solve_up(prob::SteadyStateProblem{…}, sensealg::Nothing, u0::Vector{…}, p::MTKParameters{…}, args::DynamicSS{…}; kwargs::@Kwargs{})
    @ DiffEqBase ~/.julia/packages/DiffEqBase/y5GOy/src/solve.jl:1136
 [15] solve_up
    @ ~/.julia/packages/DiffEqBase/y5GOy/src/solve.jl:1120 [inlined]
 [16] solve(prob::SteadyStateProblem{…}, args::DynamicSS{…}; sensealg::Nothing, u0::Nothing, p::Nothing, wrap::Val{…}, kwargs::@Kwargs{})
    @ DiffEqBase ~/.julia/packages/DiffEqBase/y5GOy/src/solve.jl:1057
 [17] solve(prob::SteadyStateProblem{…}, args::DynamicSS{…})
    @ DiffEqBase ~/.julia/packages/DiffEqBase/y5GOy/src/solve.jl:1047

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions