test fixes #1221
test fixes #1221
Conversation
|
This one seems to fix parts of things. But we still need #1214 (and then there is the pre-release stuff as well) |
| function isequivalent(sym1, sym2; ignored_metadata = [MT.SymScope]) | ||
| isequal(sym1, sym2) || (return false) | ||
| if any((md1 != ep_metadata) && !(md1 in sym2.metadata) for md1 in sym1.metadata) | ||
| if any((md1 != ep_metadata) && (md1[1] ∉ ignored_metadata) && (md1 ∉ sym2.metadata) | ||
| for md1 in sym1.metadata) | ||
| return false | ||
| elseif any((md2 != ep_metadata) && !(md2 in sym1.metadata) for md2 in sym2.metadata) | ||
| elseif any((md2 != ep_metadata) && (md2[1] ∉ ignored_metadata) && (md2 ∉ sym1.metadata) | ||
| for md2 in sym2.metadata) |
There was a problem hiding this comment.
Can you not just check the metadata you actually care about? Perhaps maintain a list of the important fields and just iterate through them here to check they agree? This current approach seems fragile and likely to cause issues in the future when MTK changes stuff again.
There was a problem hiding this comment.
I guess the opposite problem is that there might be metadata that we do not know about which might be useful to users. Aayush suggested this won't likely happen a lit in the future. Happy to discuss ways to make things better in the future, but right now trying to find all metadata and figure out which does/does not work will probably take quite a significant effort.
No description provided.