Catalyst does not work with ModelingToolkit v9.46

[sebapersson]

Describe the example

You might already be aware, but Catalyst.jl (and in extesion SBML importers and PEtab) cannot be loaded with ModelingToolkit v9.46.

Minimal Reproducible Example 👇

In a new environment the following should trigger the error:

] add Catalyst

Error & Stacktrace ⚠️

This is the stacktrace from the ModelingToolkit integration test failing (can also be found here, I also got the exact same error when trying to register the new version of PEtab.jl).

ReactionSystem Structure: Error During Test at /home/runner/.julia/packages/SafeTestsets/raUNr/src/SafeTestsets.jl:30
  Got exception outside of a @test
  LoadError: type Reaction has no field lhs
  Stacktrace:
    [1] getproperty
      @ ./Base.jl:49 [inlined]
    [2] collect_scoped_vars!(unknowns::OrderedCollections.OrderedSet{Any}, parameters::OrderedCollections.OrderedSet{Any}, sys::Catalyst.ReactionSystem{Catalyst.NetworkProperties{Int64, SymbolicUtils.BasicSymbolic{Real}}}, iv::SymbolicUtils.BasicSymbolic{Real}; depth::Int64, op::Type)
      @ ModelingToolkit ~/work/ModelingToolkit.jl/ModelingToolkit.jl/src/utils.jl:495
    [3] collect_scoped_vars!
      @ ~/work/ModelingToolkit.jl/ModelingToolkit.jl/src/utils.jl:492 [inlined]
    [4] complete(sys::Catalyst.ReactionSystem{Catalyst.NetworkProperties{Int64, SymbolicUtils.BasicSymbolic{Real}}}; split::Bool)
      @ ModelingToolkit ~/work/ModelingToolkit.jl/ModelingToolkit.jl/src/systems/abstractsystem.jl:929
    [5] complete(sys::Catalyst.ReactionSystem{Catalyst.NetworkProperties{Int64, SymbolicUtils.BasicSymbolic{Real}}})
      @ ModelingToolkit ~/work/ModelingToolkit.jl/ModelingToolkit.jl/src/systems/abstractsystem.jl:924
    [6] top-level scope
      @ ~/work/ModelingToolkit.jl/ModelingToolkit.jl/downstream/test/reactionsystem_core/reactionsystem.jl:44
    [7] include(mod::Module, _path::String)
      @ Base ./Base.jl:557
    [8] include(x::String)
      @ Main.var"##ReactionSystem Structure#231" ~/.julia/packages/SafeTestsets/raUNr/src/SafeTestsets.jl:28
    [9] macro expansion
      @ ~/work/ModelingToolkit.jl/ModelingToolkit.jl/downstream/test/runtests.jl:15 [inlined]
   [10] macro expansion
      @ /opt/hostedtoolcache/julia/1.11.0/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1700 [inlined]
   [11] macro expansion
      @ ~/work/ModelingToolkit.jl/ModelingToolkit.jl/downstream/test/runtests.jl:15 [inlined]
   [12] top-level scope
      @ ~/.julia/packages/SafeTestsets/raUNr/src/SafeTestsets.jl:30
   [13] eval(m::Module, e::Any)
      @ Core ./boot.jl:430
   [14] macro expansion
      @ ~/.julia/packages/SafeTestsets/raUNr/src/SafeTestsets.jl:28 [inlined]
   [15] macro expansion
      @ ./timing.jl:578 [inlined]
   [16] macro expansion
      @ ~/work/ModelingToolkit.jl/ModelingToolkit.jl/downstream/test/runtests.jl:15 [inlined]
   [17] macro expansion
      @ ./timing.jl:578 [inlined]
   [18] top-level scope
      @ ~/work/ModelingToolkit.jl/ModelingToolkit.jl/downstream/test/runtests.jl:312
   [19] include(fname::String)
      @ Main ./sysimg.jl:38
   [20] top-level scope
      @ none:6
   [21] eval
      @ ./boot.jl:430 [inlined]
   [22] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:296
   [23] _start()
      @ Base ./client.jl:531

[isaacsas]

That's unfortunate, as we can't even make a release right now due to structural identifiability not working on 1.11 last I checked, and even when we would be able to it will need to be as Catalyst V15 due to breaking changes on master here. (At least, not without backporting the fix, but that is likely not to work without also removing structural identifiability from any future v14 release.)

[sebapersson]

Thanks for the fast reply! Hopefully this can then be solved ModelingToolkit.