Skip to content

Conversation

eeshdarthvader
Copy link

@eeshdarthvader eeshdarthvader commented Nov 7, 2022

Upgrade all Dependencies using yarn upgrade-interactive --latest to remove all security vulnerabilities.

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Coverage after merging into master

100.00%
Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   html.js100%100%100%
   lcov.js100%100%100%
   tabulate.js100%100%100%

@eeshdarthvader eeshdarthvader marked this pull request as ready for review November 7, 2022 14:59
@fbenz
Copy link

fbenz commented Nov 7, 2022

I'm not surprised by the big diff in the log file but am wondering about /dist/main.js. This is a generated file, or? Is it intentionally committed?

@eeshdarthvader
Copy link
Author

I'm not surprised by the big diff in the log file but am wondering about /dist/main.js. This is a generated file, or? Is it intentionally committed?

Yes, it is autogenerated by yarn build which converts the latest JS code in action to transpiled code into the bundle /dist.main.js for node to understand and run in Pull requests.

The big diff is because of the all the new dependencies added.

I also minified the bundle now, so we don't have a huge difference.

@eeshdarthvader eeshdarthvader merged commit b3ae07c into master Nov 14, 2022
@eeshdarthvader eeshdarthvader deleted the clean_up branch November 14, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants