Update wording for clarity #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested it and the feature works fine in displaying comments that are the full 500 characters (scratch's project comment limit). The original wording, "view full comment" can then be considered confusing to the user, as they might think that the full comment isn't being displayed/is being cut off when it's just the context (replies + original message) that is missing.
Collaborator
|
Ok that's a good clarification, thanks. |
rgantzos
approved these changes
Jun 21, 2024
rgantzos
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it and the feature works fine in displaying comments that are the full 500 characters (scratch's project comment limit). The original wording, "view full comment" can then be considered confusing to the user, as they might think that the full comment isn't being displayed/is being cut off when it's just the context (replies + original message) that is missing.