Skip to content

Various additions and fixes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Various additions and fixes #1

wants to merge 7 commits into from

Conversation

LegNeato
Copy link

Let me know if you would prefer these to go in individual PRs.

@LegNeato
Copy link
Author

Friendly poke! 👉 @SSheldon

@LegNeato
Copy link
Author

@SSheldon ❓

@simlay
Copy link

simlay commented Oct 6, 2019

@SSheldon Can we merge this pull request? I cloned @LegNeato's fork and compiled it with rust 1.38. Aside from a few warnings about traits without explicit dyn's are depricated, it worked without any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LegNeato @simlay