-
Notifications
You must be signed in to change notification settings - Fork 176
Make Library OSGi-compatible #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maven now generates a Manifest file and adds it to the JAR file. However, I'm not familiar with OSGi and hope that the limitations in regards to class loading don't affect this library. If there are any problems, please let me know! |
It does look like a valid OSGi Manifest to me. Is there anything wrong with it? It's not exactly the same as the one you provided, since it's auto-generated via Maven. |
When using goals (clean package) I just see following in the manifest file in the target directory jar: |
Huh? When I run the same goal, I get the following Manifest:
So I guess, when I deploy it to Maven Central, it will be fine. |
@garpinc I have no experience with OSGi but from what I've read so far, every library has its own class loader and takes the separation of modules very seriously. Since java-object-diff relies heavily on reflection of external classes, I'm a little bit worried, whether this is even possible in an OSGi environment. Have you already tried using java-object-diff in your OSGi system and now if it works? |
I not entirely sure how it works. I'll get specifics tomorrow. But it works great.. From: Daniel Bechlermailto:[email protected] @garpinc I have no experience with OSGi but from what I've read so far, every library has its own class loader and takes the separation of modules very seriously. Since java-object-diff relies heavily on reflection of external classes, I'm a little bit worried, whether this is even possible in an OSGi environment. Have you already tried using java-object-diff in your OSGi system and now if it works? Reply to this email directly or view it on GitHub: |
That it works great is all I needed to know. Thanks! :-) |
Here are some useful resources:
The text was updated successfully, but these errors were encountered: