Skip to content

[FEATURE] Support ES2022 language features #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2022
Merged

[FEATURE] Support ES2022 language features #848

merged 3 commits into from
Nov 29, 2022

Conversation

@matz3
Copy link
Member

@matz3 matz3 commented Nov 23, 2022

JIRA: CPOUI5FOUNDATION-591

@coveralls
Copy link

coveralls commented Nov 23, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.0009%) to 94.703% when pulling 7759d2e on support-es2022 into 0e10f64 on main.

codeworrior
codeworrior requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a typo and a small copy&paste issue

@matz3 matz3 requested a review from codeworrior November 24, 2022 09:03
@codeworrior
Copy link
Member

codeworrior commented Nov 28, 2022

I checked the builder code for occurrences of MemberExpression and Identifier and couldn't find another place where PrivateIdentifier currently would have to be handled.

@matz3 matz3 merged commit f9b8457 into main Nov 29, 2022
@matz3 matz3 deleted the support-es2022 branch November 29, 2022 10:17
@ecker ecker mentioned this pull request Dec 2, 2022
Closed
17 tasks
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 25, 2025
@matz3
[builder][FEATURE] Support ES2022 language features (SAP/ui5-builder#848
e82a0c7 
)


JIRA: CPOUI5FOUNDATION-591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codeworrior codeworrior codeworrior approved these changes

@RandomByte RandomByte Awaiting requested review from RandomByte

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matz3 @coveralls @codeworrior