-
Notifications
You must be signed in to change notification settings - Fork 22
chore: Automate creating and merging documentation release notes during release #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/bump.yml
Outdated
TAG_NAME="v${{ needs.bump.outputs.version }}" | ||
echo "Attempting to delete tag ${TAG_NAME}..." | ||
git push --delete origin "${TAG_NAME}" || echo "Failed to delete tag ${TAG_NAME} (it might not exist)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only deleting the tag here, the version commit should also be reverted.
But, I think that would be easier if the commit-and-tag@main
action from cloud sdk returns a commit id.
I would do this in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round review.
…i-sdk-js into chore/add-release-notes-automation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Context
Closes SAP/ai-sdk-js-backlog#274.
What this PR does and why it is needed
Points to note:
pr-is-mergeable
action is copied over from the Java repoadd-changelog
andget-package-version
are scripts copied over from Cloud SDK JSadd-changelog
to also accomodate running the script when no initial release notes exist(was useful in testing the docs repo in the current state)bump
run that creates a PR in Docs repopublish
run that checks if PR is mergeable and fails if notpublish
it is important that we check and approve the docs PR, else auto merge of the PR fails.