Skip to content

chore: Automate creating and merging documentation release notes during release #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 14, 2025

Conversation

KavithaSiva
Copy link
Contributor

@KavithaSiva KavithaSiva commented Apr 7, 2025

Context

Closes SAP/ai-sdk-js-backlog#274.

What this PR does and why it is needed

Points to note:

  • pr-is-mergeable action is copied over from the Java repo
  • add-changelog and get-package-version are scripts copied over from Cloud SDK JS
  • minor changes were made to add-changelog to also accomodate running the script when no initial release notes exist(was useful in testing the docs repo in the current state)
  • Successful bump run that creates a PR in Docs repo
  • Docs Repo PR
  • Successful publish run that checks if PR is mergeable and fails if not
  • Before we run publish it is important that we check and approve the docs PR, else auto merge of the PR fails.

@KavithaSiva KavithaSiva marked this pull request as draft April 7, 2025 14:38
@KavithaSiva KavithaSiva changed the title chore: Automate creating and merging doc release notes during release chore: Automate creating and merging documentation release notes during release Apr 7, 2025
Comment on lines 96 to 98
TAG_NAME="v${{ needs.bump.outputs.version }}"
echo "Attempting to delete tag ${TAG_NAME}..."
git push --delete origin "${TAG_NAME}" || echo "Failed to delete tag ${TAG_NAME} (it might not exist)."
Copy link
Contributor Author

@KavithaSiva KavithaSiva Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only deleting the tag here, the version commit should also be reverted.
But, I think that would be easier if the commit-and-tag@main action from cloud sdk returns a commit id.
I would do this in a follow-up.

@KavithaSiva KavithaSiva marked this pull request as ready for review April 8, 2025 07:13
Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round review.

Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KavithaSiva KavithaSiva merged commit b2be320 into main Apr 14, 2025
10 checks passed
@KavithaSiva KavithaSiva deleted the chore/add-release-notes-automation branch April 14, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants