Fix assert failure in await expression with non-null assertion #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a debug assertion failure that occurs when using
NODE_ENV=development
with await expressions followed by non-null assertions.Issue
The following code would cause a debug assertion failure when compiled with
NODE_ENV=development
:The error was:
Root Cause
In
src/compiler/transformers/ts.ts
, thevisitNonNullExpression
function was incorrectly usingisLeftHandSideExpression
as the test when visiting the inner expression:The issue is that await expressions are unary expressions, not left-hand side expressions, so the debug assertion would fail when
NODE_ENV=development
enabled debug checks.Solution
Changed the visitor test from
isLeftHandSideExpression
toisExpression
to match the pattern used by similar transformation functions likevisitAssertionExpression
andvisitSatisfiesExpression
:Testing
awaitNonNullAssertion.ts
covering various await + non-null assertion patternsFixes #23.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.