Skip to content

Conversation

baloo
Copy link
Member

@baloo baloo commented Feb 26, 2025

No description provided.

@baloo baloo marked this pull request as draft February 26, 2025 03:11
@baloo baloo force-pushed the baloo/edition-2024 branch 5 times, most recently from b1e15a6 to bbdca6d Compare February 26, 2025 05:01
@baloo baloo force-pushed the baloo/edition-2024 branch 5 times, most recently from 5fbfb41 to 171f74a Compare February 26, 2025 07:33
@baloo baloo marked this pull request as ready for review February 26, 2025 07:33
@baloo baloo force-pushed the baloo/edition-2024 branch from 171f74a to 71e9868 Compare February 26, 2025 07:56
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you committed the .readme folder by mistake.

@baloo
Copy link
Member Author

baloo commented Feb 26, 2025

It seems you committed the .readme folder by mistake.

I just had to bump dependencies in the .readme but it's already in master:
https://github.com/RustCrypto/password-hashes/tree/master/.readme

@baloo baloo force-pushed the baloo/edition-2024 branch 2 times, most recently from 554ec5c to a307cf4 Compare February 26, 2025 17:50
@baloo baloo force-pushed the baloo/edition-2024 branch 4 times, most recently from f68d373 to d315fed Compare February 26, 2025 18:11
@newpavlov
Copy link
Member

newpavlov commented Feb 26, 2025

Ah, I forgot that .readme is used to test the root README example.

It may be worth to add it to the workspace so we wouldn't have a separate Cargo.lock, but we probably can leave it for a later PR.

@baloo baloo force-pushed the baloo/edition-2024 branch from d315fed to bf89658 Compare February 26, 2025 20:06
@baloo baloo force-pushed the baloo/edition-2024 branch from bf89658 to 913cfad Compare February 26, 2025 20:28
@baloo
Copy link
Member Author

baloo commented Feb 28, 2025

Anything else needed here?

@newpavlov newpavlov merged commit 1dd9906 into RustCrypto:master Feb 28, 2025
60 checks passed
@baloo baloo deleted the baloo/edition-2024 branch February 28, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants