feat: update to latest round of traits and rand 0.9 #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Still debugging some failing tests currently |
|
Tests are mostly passing, no idea why crypto_secretstream wasm builds fail, they are passing locally.. |
|
It looks like |
|
@dignifiedquire I wonder if #177 might've caused that (i.e. adding clamping) |
|
@tarcieri yep, I hadn't seen that PR, that is exactly what breaks things, undoing that change makes things work again |
tarcieri
approved these changes
Sep 29, 2025
|
@dignifiedquire might bikeshed the name in a followup, but this is fine for now |
|
@tarcieri any chance I can get a pre-release of this? |
|
which one(s) specifically? |
|
I just need |
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Oct 6, 2025
## Description - Upgrade to [email protected] - Upgrade dalek crates to prereleases Blocked on - [x] RustCrypto/nacl-compat#182 - [x] pubky/mainline#71 - [x] pubky/pkarr#186 Closes #3198 ## Breaking Changes - interfaces that depend on `rand` now need `0.9` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs some review & feedback for feature naming & usage of the new inout buffers
Closes #176