rust: take str literal instead bstr literal in module! macro
#858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojeda
reviewed
Aug 5, 2022
rust/macros/helpers.rs
Outdated
| @@ -28,6 +28,21 @@ pub(crate) fn try_byte_string(it: &mut token_stream::IntoIter) -> Option<String> | |||
| }) | |||
| } | |||
|
|
|||
| pub(crate) fn try_string(it: &mut token_stream::IntoIter) -> Option<String> { | |||
| try_literal(it).and_then(|string| { | |||
| // TODO: handle raw string literals | |||
There was a problem hiding this comment.
Maybe as documentation of the function, to avoid the TODO (if we do not expect tot need raw literals).
Or maybe panic, if you can detect it is a raw literal?
|
It could be good to have a |
For simplicity (avoid parsing), escape sequences and raw string literals are not yet handled. Module names, aliases and license strings are restricted to ASCII only. Link: Rust-for-Linux#252 Link: https://lore.kernel.org/lkml/[email protected]/ Signed-off-by: Gary Guo <[email protected]>
|
Thanks Gary! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a complete fix to #252 because only a subset of string literals are accepted: For simplicity (avoid parsing), escape sequences are not yet handled.